feat(config): Add supervisor programs dependency validation#275
Conversation
devservices/utils/dependencies.py
Outdated
| else DependencyType.COMPOSE, | ||
| dependency_type=( | ||
| DependencyType.SERVICE | ||
| if _has_remote_config(dependency.remote) |
There was a problem hiding this comment.
This is a pretty huge change, but seems safe to do given that the type is determined during the validation of config now
There was a problem hiding this comment.
To start out, if there are remote dependencies are in modes that include supervisor programs, they should be completely disabled. We don't want to support those workflows since a lot of the time it involves ensuring the venv is set up properly and the right directory is cd'd into
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 94.88% 94.93% +0.05%
==========================================
Files 27 27
Lines 2249 2272 +23
==========================================
+ Hits 2134 2157 +23
Misses 115 115 ☔ View full report in Codecov by Sentry. |
hubertdeng123
deleted the
hubertdeng123/supervisor-programs-dependency-validation
branch
2 participants
This adds safeguards to ensure that non-remote dependencies must have a docker compose service or supervisor program
part of https://linear.app/getsentry/issue/DI-762/config-validation-for-dependencies